[Lldb-commits] [PATCH] D124568: [lldb] Fix escaping when launching in terminal with AppleScript

[Adrian Prantl via Phabricator via lldb-commits]

aprantl added inline comments.


================
Comment at: lldb/source/Host/macosx/objcxx/Host.mm:222
   if (working_dir)
-    command.Printf(" --working-dir '%s'", working_dir.GetCString());
+    command.Printf(" --working-dir \\\"%s\\\"", working_dir.GetCString());
   else {
----------------
Should we use raw C++ string literals for this?
https://en.cppreference.com/w/cpp/language/string_literal


================
Comment at: lldb/source/Host/macosx/objcxx/Host.mm:267
+
+  printf("%s\n", applescript_source.GetString().str().c_str());
+
----------------
Is this leftover debugging code?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124568/new/

https://reviews.llvm.org/D124568

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits