yinghuitan added a comment.

Also, to help diagnostics this kind of issue in future, it may worth to add an 
extra debug mode check in in `UniqueCStringMap` to ensure they are sorted. For 
example, in debug mode, add a `m_isSorted` flag which is set by 
`UniqueCStringMap::Sort()` method. All the binary search methods should assert 
`m_isSorted == true`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124572/new/

https://reviews.llvm.org/D124572

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to