aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land.
Few nitpicks inside otherwise I'm happy. ================ Comment at: lldb/include/lldb/Interpreter/OptionGroupValueObjectDisplay.h:50 uint32_t max_depth; + bool max_depth_is_default; uint32_t ptr_depth; ---------------- Should this be with the other bools on line 45? ================ Comment at: lldb/include/lldb/Target/Target.h:169 + std::pair<uint32_t, bool> GetMaximumDepthOfChildrenToDisplay() const; + ---------------- Doxygen comment to explain what the bool returns? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123954/new/ https://reviews.llvm.org/D123954 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
