wallace added inline comments.
================
Comment at: lldb/source/Plugins/Process/Linux/IntelPTCollector.cpp:40
+IntelPTCollector::FetchPerfTscConversionParameters() {
+ if (!m_cached_tsc_conversion) {
+ if (Expected<LinuxPerfZeroTscConversion> tsc_conversion =
----------------
jj10306 wrote:
> Don't we want to always reload the parameters here (ie not do this check)
> since they could potentially change or is that not the case?
> We had discussions about this when I initially added the tsc conversion logic
> but I can't remember so maybe you can help refresh my memory:
ahh, that's a good point. We should favor the most recent instructions, which
means favoring the most recent conversion params
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125932/new/
https://reviews.llvm.org/D125932
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
