clayborg added inline comments.
================
Comment at: lldb/tools/lldb-vscode/BreakpointBase.cpp:126
+ const llvm::StringRef &expr = bp->evalExpressions[i];
+ // TODO: try local variables first.
+ lldb::SBValue value = frame.EvaluateExpression(expr.str().c_str());
----------------
I would definitely try an local variable paths first via:
```
lldb::SBValue value =
frame.GetValueForVariablePath(part.text.str().c_str(),
lldb::eDynamicDontRunTarget);
```
before doing the evaluate expression due to performance which will be important
in this case.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D127702/new/
https://reviews.llvm.org/D127702
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
