alvinhochun added a comment. Herald added a subscriber: Michael137. In D126367#3580683 <https://reviews.llvm.org/D126367#3580683>, @labath wrote:
> Is there any difference in functionality between SymbolVendorELF and the new > class introduced here? Could this have been achieved by teaching > SymbolVendorELF (after renaming it to something else) to handle COFF files as > well? There is a slight difference with the elements in the `g_sections` list, which I mentioned in an inline comment. (https://reviews.llvm.org/D126367#inline-1214432 I also mentioned removing the UUID check but it has been re-added with the CRC handling in place.) Yes, it could probably be combined with SymbolVendorELF. Perhaps I should also say, what led me to make a separate class SymbolVendorPECOFF instead, is the pre-existing SymbolVendorWasm class, which also has very similar code to SymbolVendorELF. It gave the impression that each object file format should have its own SymbolVendor plugin. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126367/new/ https://reviews.llvm.org/D126367 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
