mgorny marked an inline comment as done.
mgorny added inline comments.
================
Comment at:
lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:1967
+
+ if (multiprocess) {
+ for (auto &pid_ptr : m_debugged_processes)
----------------
labath wrote:
> without multiprocess extensions, we should never have more than one process,
> right? Could we just unconditionally use the multiprocess loop here (perhaps
> with an `assert(m_debugged_processes.size() == 1 || multiprocess)`) ?
Yes, that makes sense. We enable fork & vfork only if multiprocess is
supported, so that shouldn't happen unless we deal with broken Process plugin.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128152/new/
https://reviews.llvm.org/D128152
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
