aprantl added inline comments.
================
Comment at: lldb/source/Plugins/Language/CPlusPlus/LibCxx.cpp:637
if (location_sp->GetName() == g_size_name)
- location_sp = short_sp->GetChildAtIndex(3, true);
+ location_sp = short_sp->GetChildAtIndex(2, true);
if (using_bitmasks)
----------------
Let me know if I',m misunderstanding what the code is doing, but this looks
like it is replacing the previous implementation? Ideally we would detect the
layout and then parse it correctly depending on which version we're dealing
with. Otherwise we risk breaking the matrix bot that checks that LLDB can debug
C++ produced by older versions of LLVM (and by extension libcxx).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128694/new/
https://reviews.llvm.org/D128694
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
