DavidSpickett added a comment. I'll give this a more thorough read later just one comment for now.
In the meantime, what's your plan for testing this config going forward? This patch would be fine as the first of a series but I'd like to see the follow ups that make it usable. Will there be a build bot? You could at least enable building lldb on an existing riscv bot, while you iron out all the inevitable test suite issues. ================ Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_riscv64.h:9 + +#if defined(__riscv) || __riscv_xlen == 64 + ---------------- Should this be `&&`? I'm assuming that `__riscv` is also defined for riscv32. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128250/new/ https://reviews.llvm.org/D128250 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
