DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land.
Looks good from my perspective. ================ Comment at: lldb/test/API/macosx/unregistered-macho/main.c:48 + memcpy(p, &uuid, sizeof(uuid)); + p += sizeof(uuid); + ---------------- jasonmolenda wrote: > DavidSpickett wrote: > > This is redundant (the test uses `macho_buf`). > I needed to increment `p` so it points to the end of the mach-o image if I > want to write it to disk and try sending it through `otool` for testing. > You're right though, this has no effect to the program itself. Got it, now I see it in the comments below. Fair enough. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128956/new/ https://reviews.llvm.org/D128956 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
