yinghuitan added inline comments.
================
Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:1939-1950
+ uint32_t addr_size = frame.GetThread().GetProcess().GetAddressByteSize();
+ const uint32_t num_reg_sets = g_vsc.variables.registers.GetSize();
+ for (uint32_t reg_set_idx=0; reg_set_idx<num_reg_sets; ++reg_set_idx) {
+ lldb::SBValue reg_set =
+ g_vsc.variables.registers.GetValueAtIndex(reg_set_idx);
+ const uint32_t num_regs = reg_set.GetNumChildren();
+ for (uint32_t reg_idx=0; reg_idx<num_regs; ++reg_idx) {
----------------
The change looks good. But I do not think we should pay this cost during each
stop. Can we only call this when user expands "registers" scope?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D129528/new/
https://reviews.llvm.org/D129528
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
