DavidSpickett added a comment. Seems fine to me. Do you have a tracking issue for this? You could just open one for "lldb riscv test failures" and add comments as you find more failures. So people can see the current state of the test suite.
================ Comment at: lldb/unittests/Core/DumpDataExtractorTest.cpp:202 +#if !defined(__riscv) // quiet/signaling NaNs. ---------------- Add a brief comment with the reason, "riscv does not support...." just a one liner. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129736/new/ https://reviews.llvm.org/D129736 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
