JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
A few nits about naming, but otherwise this LGTM.
================
Comment at:
lldb/tools/lldb-fuzzer/lldb-expression-fuzzer/lldb-expression-fuzzer.cpp:47
+DEFINE_BINARY_PROTO_FUZZER(const clang_fuzzer::Function &input) {
+ auto S = clang_fuzzer::FunctionToString(input);
+
----------------
================
Comment at:
lldb/tools/lldb-fuzzer/lldb-expression-fuzzer/lldb-expression-fuzzer.cpp:51-52
+ // This will be used as the path for the object file to create a target from
+ std::string rawpath = originalargv[2];
+ StringRef objpath = rawpath.erase(0, 2);
+
----------------
================
Comment at:
lldb/tools/lldb-fuzzer/lldb-expression-fuzzer/lldb-expression-fuzzer.cpp:59
+ // Create a breakpoint on the only line in the program
+ SBBreakpoint bp = target.BreakpointCreateByLocation(objpath.str().c_str(),
1);
+
----------------
================
Comment at:
lldb/tools/lldb-fuzzer/lldb-expression-fuzzer/lldb-expression-fuzzer.cpp:62
+ // Create launch info and error for launching the process
+ SBLaunchInfo li = target.GetLaunchInfo();
+ SBError error;
----------------
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D129377/new/
https://reviews.llvm.org/D129377
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
