rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land.
Thanks! ================ Comment at: lldb/source/Plugins/SymbolFile/NativePDB/PdbAstBuilder.cpp:840 + spelling = + clang::MSInheritanceAttr::Spelling::Keyword_multiple_inheritance; + break; ---------------- This should be virtual, not multiple, right? ================ Comment at: lldb/test/Shell/SymbolFile/NativePDB/ast-types.cpp:111 +MITYPE *mp7 = nullptr; +VI2TYPE *mp8 = nullptr; + ---------------- It's worth adding tests for data member pointers as well as function member pointers, in particular ones that use -1 as the null representation. Try this: ``` int SI::*mp9 = nullptr; ``` Because offset zero is a valid offset, -1 is used to represent null in this case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129807/new/ https://reviews.llvm.org/D129807 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
