labath accepted this revision.
labath added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lldb/source/Commands/CommandObjectType.cpp:1064
+    // No regex means list everything.
+    return (regex == nullptr || (s == regex->GetText() || regex->Execute(s)));
+  }
----------------
What's up with all the parentheses? This is just a regular `||` between three 
choices...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130219/new/

https://reviews.llvm.org/D130219

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to