[Lldb-commits] [PATCH] D130320: Move GetControlFlowKind's logic to DisassemblerLLVMC.cpp

[walter erquinigo via Phabricator via lldb-commits]

wallace added a comment.

Just one more change and good to go



================
Comment at: lldb/include/lldb/Core/Disassembler.h:87
+  virtual lldb::InstructionControlFlowKind
+  GetControlFlowKind(const ExecutionContext *exe_ctx) = 0;
 
----------------
could add a default implementation here? 

 {
    return lldb::eInstructionControlFlowKindUnknown;
  }

that way you won't break any other class that extends Instruction.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130320/new/

https://reviews.llvm.org/D130320

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits