Author: Slava Gurevich Date: 2022-08-02T15:56:23-07:00 New Revision: 4502e3531f623c47e71d3a159580a72560b90954
URL: https://github.com/llvm/llvm-project/commit/4502e3531f623c47e71d3a159580a72560b90954 DIFF: https://github.com/llvm/llvm-project/commit/4502e3531f623c47e71d3a159580a72560b90954.diff LOG: [LLDB][NFC] Fix incorrect return status Some functions always return 'false' for both success and fail return paths. Differential Revision: https://reviews.llvm.org/D131013 Added: Modified: lldb/source/Plugins/Language/ObjC/NSArray.cpp lldb/source/Plugins/Language/ObjC/NSDictionary.cpp lldb/source/Plugins/Language/ObjC/NSSet.cpp Removed: ################################################################################ diff --git a/lldb/source/Plugins/Language/ObjC/NSArray.cpp b/lldb/source/Plugins/Language/ObjC/NSArray.cpp index adda04e18629c..876efda9b988f 100644 --- a/lldb/source/Plugins/Language/ObjC/NSArray.cpp +++ b/lldb/source/Plugins/Language/ObjC/NSArray.cpp @@ -532,9 +532,8 @@ lldb_private::formatters:: process_sp->ReadMemory(data_location, m_data_64, sizeof(D64), error); } - if (error.Fail()) - return false; - return false; + + return error.Success(); } bool @@ -675,9 +674,8 @@ lldb_private::formatters::GenericNSArrayISyntheticFrontEnd<D32, D64, Inline>:: process_sp->ReadMemory(data_location, m_data_64, sizeof(D64), error); } - if (error.Fail()) - return false; - return false; + + return error.Success(); } template <typename D32, typename D64, bool Inline> diff --git a/lldb/source/Plugins/Language/ObjC/NSDictionary.cpp b/lldb/source/Plugins/Language/ObjC/NSDictionary.cpp index e5e62b534560a..be74338258283 100644 --- a/lldb/source/Plugins/Language/ObjC/NSDictionary.cpp +++ b/lldb/source/Plugins/Language/ObjC/NSDictionary.cpp @@ -1121,9 +1121,8 @@ lldb_private::formatters::GenericNSDictionaryMSyntheticFrontEnd<D32,D64>:: process_sp->ReadMemory(data_location, m_data_64, sizeof(D64), error); } - if (error.Fail()) - return false; - return true; + + return error.Success(); } template <typename D32, typename D64> @@ -1284,9 +1283,8 @@ lldb_private::formatters::Foundation1100:: process_sp->ReadMemory(data_location, m_data_64, sizeof(DataDescriptor_64), error); } - if (error.Fail()) - return false; - return false; + + return error.Success(); } bool diff --git a/lldb/source/Plugins/Language/ObjC/NSSet.cpp b/lldb/source/Plugins/Language/ObjC/NSSet.cpp index b5c8e849abccb..fac8594d0c7d9 100644 --- a/lldb/source/Plugins/Language/ObjC/NSSet.cpp +++ b/lldb/source/Plugins/Language/ObjC/NSSet.cpp @@ -461,7 +461,7 @@ bool lldb_private::formatters::NSSetISyntheticFrontEnd::Update() { if (error.Fail()) return false; m_data_ptr = data_location + m_ptr_size; - return false; + return true; } bool lldb_private::formatters::NSSetISyntheticFrontEnd::MightHaveChildren() { @@ -735,9 +735,7 @@ lldb_private::formatters:: process_sp->ReadMemory(data_location, m_data_64, sizeof(D64), error); } - if (error.Fail()) - return false; - return false; + return error.Success(); } template <typename D32, typename D64> _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
