thieta added a comment. In D130689#3706263 <https://reviews.llvm.org/D130689#3706263>, @aaron.ballman wrote:
> > Something odd is going on here and we might want to consider a revert of this > patch until we resolve it. When I do a git pull and cmake files change, > Visual Studio's built-in CMake support automatically re-runs the configure > step. This should be all that's necessary to switch the toolchain, but it > isn't for some reason (today's build is also failing for me with C++17 > related issues after I did another pulldown this morning). I deleted my cache > explicitly and regenerated CMake from scratch and am still getting the same > build errors. The failures I am getting are the same as what's shown by the > sanitizer bot for Windows: > https://lab.llvm.org/buildbot/#/builders/127/builds/33980/steps/4/logs/stdio > (I'm using VS 2019 16.11.17 FWIW). > > I hope we can resolve this quickly as basically no MSVC builds are green > right now in the build lab. While we can revert this one - we also need to revert all changes that add C++17 features at this point as well. That will be a lot of churn. Let's see if we can figure out what's wrong first. Can you try to locally rebuild with this patch https://reviews.llvm.org/D131382 ? I think all the runtime errors is because of that one above - basically we don't set std=c++17 for any of the compiler-rt projects. I also think we should merge https://reviews.llvm.org/D131367 for now - we can revert that later on if we think it adds to much complexity, since it will delete the bad cache values automatcially. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130689/new/ https://reviews.llvm.org/D130689 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
