fdeazeve added inline comments.
================
Comment at:
lldb/source/Plugins/LanguageRuntime/CPlusPlus/ItaniumABI/ItaniumABILanguageRuntime.cpp:457
+ filter_modules.EmplaceBack("libc++abi.1.0.dylib");
+ filter_modules.EmplaceBack("libc++abi.1.dylib");
}
----------------
aprantl wrote:
> fdeazeve wrote:
> > aprantl wrote:
> > > Should these be ordered such that the most likely matches on the most
> > > modern systems come first?
> > According to @jasonmolenda, the order is not relevant from a practical
> > point of view, as breakpoints will be set in _all_ of the above (if they
> > exist). Unless your intent here is for readers to know which files are more
> > common?
> I also just realized that the ones you added here are the less common ones.
> So this LGTM
For the reference of future readers, my previous comment was incorrect, as I
had misinterpreted something. The order matters in that, whenever a new dylib
is loaded, its name is checked against this list. The earlier the match, the
earlier we stop the search.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132598/new/
https://reviews.llvm.org/D132598
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
