labath accepted this revision.
labath added a comment.

Seems reasonable. BTW, these days, I don't think anybody is invoking `make` 
directly from the command line, so it would be fine (maybe even desirable) to 
move some of this logic into python code -- particularly if it makes windows 
compatibility easier.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133002/new/

https://reviews.llvm.org/D133002

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
  • [Lldb-commits] [PAT... Muhammad Omair Javaid via Phabricator via lldb-commits
    • [Lldb-commits]... Martin Storsjö via Phabricator via lldb-commits
    • [Lldb-commits]... Pavel Labath via Phabricator via lldb-commits
    • [Lldb-commits]... Muhammad Omair Javaid via Phabricator via lldb-commits

Reply via email to