[Lldb-commits] [PATCH] D133069: Fix inconsistent target arch when attaching to arm64 binaries on arm64e platforms.

[Adrian Prantl via Phabricator via lldb-commits]

aprantl added inline comments.


================
Comment at: 
lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderDarwin.cpp:584
+        triple.setArchName("arm64");
+        target_arch.SetTriple(triple);
+        target.SetArchitecture(target_arch, /*set_platform=*/false,
----------------
JDevlieghere wrote:
> Why can't you set the `target_arch` to 
> `exe_module_sp->GetArchitecture().GetTriple()`? 
That would be shorter. I was worried that could undo any mac catalyst versus 
macos fixups we did in DynamicLinkerDarwin before.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133069/new/

https://reviews.llvm.org/D133069

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits