labath accepted this revision. labath added inline comments.
================ Comment at: lldb/packages/Python/lldbsuite/test/make/Makefile.rules:381-386 +ifneq ($(and $(USE_LIBSTDCPP), $(USE_LIBCPP)),) + $(error Libcxx and Libstdc++ cannot be used together) +endif + +ifeq (1, $(USE_SYSTEM_STDLIB)) + ifneq ($(or $(USE_LIBSTDCPP), $(USE_LIBCPP)),) ---------------- fdeazeve wrote: > labath wrote: > > Instead of three distinct variables, it might be nicer to just have one > > argument (STDLIB_KIND ?) which can take three different values... > I think this could be an improvement, but since it would involve changing > _all_ makefiles that define these variables, IMO it would be better to do it > in a separate NFC change, if that's ok Ok, I'm going to hold you to that. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132940/new/ https://reviews.llvm.org/D132940 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
