Author: Jim Ingham Date: 2022-09-13T14:09:44-07:00 New Revision: 81f8788528886ee611041e1f4ee54eea8bbfa277
URL: https://github.com/llvm/llvm-project/commit/81f8788528886ee611041e1f4ee54eea8bbfa277 DIFF: https://github.com/llvm/llvm-project/commit/81f8788528886ee611041e1f4ee54eea8bbfa277.diff LOG: Trying to understand the TestHelp.py failure from 6c089b2. Sadly, the test passes on macOS, but fails on Ubuntu & Win. The extra option printing is supposed to be suppressed by the return from CommandObjectAlias::IsDashDashCommand. That was changed, but just by replacing an inline string compare with a const string from CommandInterpreter. Putting the old version back temporarily to see if that is really the problem. Added: Modified: lldb/source/Interpreter/CommandAlias.cpp Removed: ################################################################################ diff --git a/lldb/source/Interpreter/CommandAlias.cpp b/lldb/source/Interpreter/CommandAlias.cpp index e36edcac15a5..80a926ef4d6a 100644 --- a/lldb/source/Interpreter/CommandAlias.cpp +++ b/lldb/source/Interpreter/CommandAlias.cpp @@ -180,7 +180,7 @@ bool CommandAlias::IsDashDashCommand() { for (const auto &opt_entry : *GetOptionArguments()) { std::tie(opt, std::ignore, value) = opt_entry; - if (opt == CommandInterpreter::g_argument && !value.empty() && + if (opt == "<argument>" && !value.empty() && llvm::StringRef(value).endswith("--")) { m_is_dashdash_alias = eLazyBoolYes; break; _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits