mib created this revision.
mib added a reviewer: kastiglione.
mib added a project: LLDB.
Herald added subscribers: JDevlieghere, kristof.beyls.
Herald added a project: All.
mib requested review of this revision.
Herald added a subscriber: lldb-commits.
This patch adds support for 32bit stack frame addresses in the `crashlog`
command.
For crash reports that a generated from a arm64_32 process, `PAGEZERO` is
loaded at 0x00004000 so no code address will be less than 0x4000.
This patch changes the crashlog frame address regex group to match
addresses as small as 4 hex characters.
rdar://100805026
Signed-off-by: Med Ismail Bennani <medismail.benn...@gmail.com>
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D135310
Files:
lldb/examples/python/crashlog.py
Index: lldb/examples/python/crashlog.py
===================================================================
--- lldb/examples/python/crashlog.py
+++ lldb/examples/python/crashlog.py
@@ -642,7 +642,7 @@
frame_regex = re.compile(r'^(\d+)\s+' # id
r'(.+?)\s+' # img_name
r'(?:' +version+ r'\s+)?' # img_version
- r'(0x[0-9a-fA-F]{7,})' # addr (7 chars or more)
+ r'(0x[0-9a-fA-F]{4,})' # addr (4 chars or more)
r' +(.*)' # offs
)
null_frame_regex = re.compile(r'^\d+\s+\?\?\?\s+0{7,} +')
Index: lldb/examples/python/crashlog.py
===================================================================
--- lldb/examples/python/crashlog.py
+++ lldb/examples/python/crashlog.py
@@ -642,7 +642,7 @@
frame_regex = re.compile(r'^(\d+)\s+' # id
r'(.+?)\s+' # img_name
r'(?:' +version+ r'\s+)?' # img_version
- r'(0x[0-9a-fA-F]{7,})' # addr (7 chars or more)
+ r'(0x[0-9a-fA-F]{4,})' # addr (4 chars or more)
r' +(.*)' # offs
)
null_frame_regex = re.compile(r'^\d+\s+\?\?\?\s+0{7,} +')
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
