JDevlieghere added a comment.
I'm not sure I understand how the test is exercising the application specific
backtrace. I don't see any of the frames or the crash reason in there. What am
I missing?
================
Comment at: lldb/examples/python/crashlog.py:581-597
+ def parse_asi_backtrace(self, thread, bt):
+ for line in bt.split('\n'):
+ frame_match = TextCrashLogParser.frame_regex.search(line)
+ if not frame_match:
+ print("error: can't parse application specific backtrace.")
+ return False
+
----------------
Can this be a top level function? It's hard to tell if this is capturing
anything. We have other place where we have helper functions that are called
from a loop.
================
Comment at:
lldb/examples/python/scripted_process/crashlog_scripted_process.py:151-153
self.name = self.backing_thread.name
+ if self.backing_thread.app_specific_backtrace:
+ self.name = "Application Specific Backtrace - " + str(self.idx)
----------------
nit
================
Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp:1000
+ StructuredData::Array *arr = val->GetAsArray();
+ if (!arr || !arr->GetSize())
+ return false;
----------------
Should this check if the size == 1?
================
Comment at: lldb/source/Plugins/Process/scripted/ScriptedProcess.cpp:491
+
+ Status error;
+
----------------
Is this ever populated?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126260/new/
https://reviews.llvm.org/D126260
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
