DavidSpickett added a reviewer: DavidSpickett.
DavidSpickett added a comment.
This LGTM thanks for the fix just one comment on the test.
================
Comment at:
lldb/test/API/lang/cpp/type_lookup_duplicate/TestCppTypeLookupDuplicate.py:16
+
+ self.expect("image lookup -A -t Foo", DATA_TYPES_DISPLAYED_CORRECTLY,
substrs=["2 matches found", "\nid =", "\nid ="])
----------------
Could you match the whole string here? A bit easier to see at a glance that
way. Unless the output is not stable?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135827/new/
https://reviews.llvm.org/D135827
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
