aeubanks added inline comments.
================ Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1534 + std::string qualified_name; + DWARFDIE parent_decl_ctx_die = die.GetParentDeclContextDIE(); + // TODO: change this to get the correct decl context parent.... ---------------- shafik wrote: > So it looks like you can do `SymbolFileDWARF::GetDWARFDeclContext(...)` and > `DWARFDeclContext` has `GetQualifiedName()` which I think is doing what you > are doing below and maybe handles more cases. `DWARFDeclContext` doesn't have access to the clang AST, which in D134378 we will use to reconstruct template parameters (I hope I'm understanding your suggestion correctly, still new to lldb) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135979/new/ https://reviews.llvm.org/D135979 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
