labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Okay, sounds good then.
================
Comment at: lldb/source/Plugins/SymbolFile/NativePDB/PdbAstBuilder.cpp:1413-1414
if (context.isTranslationUnit()) {
- ParseAllNamespacesPlusChildrenOf(llvm::None);
+ ParseAllTypes();
+ ParseAllFunctionsAndNonLocalVars();
return;
----------------
I have a feeling this is still doing more work than it would be necessary. I
haven't checked, but I'd expect that here it should be sufficient to parse only
the top level namespace names (not their contents), and create forward
declarations for the classes in the global namespace. I suspect this is doing
much more than that.
(Of course, if PDB makes it hard to parse just this information, then it might
actually be better to parse everything -- I just don't know)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136006/new/
https://reviews.llvm.org/D136006
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
