seehearfeel added a comment. In D136578#3881955 <https://reviews.llvm.org/D136578#3881955>, @DavidSpickett wrote:
> This LGTM from the lldb side. OK, thank you. > Feel free to upload a series of patches in future if you want. You don't have > to do one at a time, just update the whole stack as needed. Plus it gives the > reviewers some context of what the changes are working towards. I am a newcomer, here are some of my thoughts: (1) Add the minimal changes to fix the build errors. (2) Submit other more patches step by step to make the basic command "run", "breakpoint", "next" ... can be used to debug, single patch or patch series. (3) Add more code to make more commands work well. > Do you have commit access? If not it's fine to wait until you have > (https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access), or > someone else can land on your behalf. Just provide a name and email address > you'd like to be on the commit. I have no commit access now, @SixWeining luwein...@loongson.cn can land on my behalf, here are my name and email: Tiezhu Yang yangtie...@loongson.cn Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136578/new/ https://reviews.llvm.org/D136578 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
