aeubanks added inline comments.
================ Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:3809 +ConstString TypeSystemClang::GetBaseName(lldb::opaque_compiler_type_t type) { + if (!type) ---------------- this was mostly copied from `GetTypeName` above, not sure if these two should be factored out? ================ Comment at: lldb/test/API/lang/cpp/unique-types2/main.cpp:20 + FooPack<int, int> t6; + FooPack<int, int, int> t7; + // Set breakpoint here ---------------- Michael137 wrote: > aeubanks wrote: > > labath wrote: > > > Would it be interesting to test nested types as well (`Foo<T>::Bar<U>`) ? > > yes, and that caught a bug, thanks for the suggestion > > > > I've added a `Type::GetBaseName()`, could you take a look at that? > Out of curiosity, what was the issue with using the qualified name? `GetQualifiedName` returns the name including any scopes, so in this case it gave `Foo<int>::Nested<char>` rather than `Nested<char>` and the `'<'` string logic ended up comparing `<int>::Nested<char>` to `<char>` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134378/new/ https://reviews.llvm.org/D134378 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits