jj10306 created this revision. jj10306 added reviewers: wallace, persona0220. Herald added a project: All. jj10306 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits.
Mention that the LLVM/clang triple must be provided if the trace will be consumed via `SBTraceCursor` Test Plan: Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D137509 Files: lldb/source/Plugins/Trace/intel-pt/TraceIntelPTBundleLoader.cpp Index: lldb/source/Plugins/Trace/intel-pt/TraceIntelPTBundleLoader.cpp =================================================================== --- lldb/source/Plugins/Trace/intel-pt/TraceIntelPTBundleLoader.cpp +++ lldb/source/Plugins/Trace/intel-pt/TraceIntelPTBundleLoader.cpp @@ -241,6 +241,7 @@ "pid": integer, "triple"?: string, // Optional clang/llvm target triple. + // This must be provided if the trace will be consumed using `SBTraceCursor`. "threads": [ // A list of known threads for the given process. When context switch // data is provided, LLDB will automatically create threads for the
Index: lldb/source/Plugins/Trace/intel-pt/TraceIntelPTBundleLoader.cpp =================================================================== --- lldb/source/Plugins/Trace/intel-pt/TraceIntelPTBundleLoader.cpp +++ lldb/source/Plugins/Trace/intel-pt/TraceIntelPTBundleLoader.cpp @@ -241,6 +241,7 @@ "pid": integer, "triple"?: string, // Optional clang/llvm target triple. + // This must be provided if the trace will be consumed using `SBTraceCursor`. "threads": [ // A list of known threads for the given process. When context switch // data is provided, LLDB will automatically create threads for the
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits