akyrtzi added a comment. In D139066#3964353 <https://reviews.llvm.org/D139066#3964353>, @jasonmolenda wrote:
> FWIW I think the only change needed to the original patch is to keep using > `#define RESOLVED_FRAME_CODE_ADDR (uint32_t(eSymbolContextEverything + 1))` > but switch to the new eSymbolContextLastItem that is defined. Possibly the > comment about what this code is doing could be made a little clearer, because > it is definitely not. :) Thank you for the feedback, but it's unclear to me what you mean, are you saying leave the `#define RESOLVED_FRAME_CODE_ADDR` line unmodified? If yes, what does "switch to the new eSymbolContextLastItem" mean? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139066/new/ https://reviews.llvm.org/D139066 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
