DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land.
> If some script _is_ manually parsing the .def, it ought to be easy enough to > update it to read the .cpp instead (it probably shouldn't do either). True. Hopefully the target parser library approach will give us a nice way to query all this stuff without manual conversion. This LGTM with the small test change done. ================ Comment at: lldb/test/Shell/Commands/command-disassemble-aarch64-extensions.s:28 + fmlal v0.2s, v1.2h, v2.2h // AEK_FP16FML + bc.eq lbl // AEK_HBC + smmla v1.4s, v16.16b, v31.16b // AEK_I8MM ---------------- This one always trips me up because the offset changes when I update the test. Can you move `lbl` to the start, or just use `fn` as the label, if that works? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139102/new/ https://reviews.llvm.org/D139102 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
