bulbazord added inline comments.
================
Comment at: lldb/include/lldb/Interpreter/ScriptedPlatformInterface.h:14
+#include "lldb/Interpreter/ScriptedInterface.h"
+#include "lldb/Target/MemoryRegionInfo.h"
+
----------------
What is `MemoryRegionInfo.h` for?
================
Comment at: lldb/include/lldb/Interpreter/ScriptedPlatformInterface.h:36-42
+ virtual Status LaunchProcess() {
+ return Status("ScriptedPlatform cannot launch process");
+ }
+
+ virtual Status KillProcess(lldb::pid_t pid) {
+ return Status("ScriptedPlatform cannot kill process");
+ }
----------------
The status messages should probably refer to `ScriptedPlatformInterface`
instead of `ScriptedPlatform` to be clearer.
================
Comment at:
lldb/source/Plugins/ScriptInterpreter/Python/ScriptedPlatformPythonInterface.cpp:1-2
+//===-- ScriptedPlatformPythonInterface.cpp
+//--------------------------------===//
+//
----------------
This header is also broken.
================
Comment at:
lldb/source/Plugins/ScriptInterpreter/Python/ScriptedPlatformPythonInterface.h:1-2
+//===-- ScriptedPlatformPythonInterface.h ------------------------*- C++
+//-*-===//
+//
----------------
The header is a little broken here.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139251/new/
https://reviews.llvm.org/D139251
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
