dblaikie added inline comments.

================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1251
+          if (has_template_params &&
+              ParseTemplateParameterInfos(die, template_param_infos)) {
+            template_function_decl = m_ast.CreateFunctionDeclaration(
----------------
This part changes behavior, yeah? (previously the code was only conditional on 
`has_template_params` and is now conditional on both that and there actually 
being template parameter DIEs) Was that intended? If so, is there any testing 
that could be done to demonstrate the change in behavior?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139649/new/

https://reviews.llvm.org/D139649

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to