eloparco added inline comments.
================
Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:2194
+ if (index == sb_instructions.size() + 1) {
+ fprintf(stderr, "current line not found in disassembled instructions\n");
+ return response_instructions;
----------------
clayborg wrote:
> Remove any and all printf, or fprintf statements. You can't print anything to
> stderr or stdout as this is where the DAP packets are get emitted to. We do
> make it so this won't affect lldb-vscode by doing some magic with the
> STDOUT/STDERR file handles, but this output will be sent to /dev/null most
> likely. You can print something to a console (using "g_vsc.SendOutput(...)"
> is one way).
I suppose I have to replace `llvm::errs()` too, right?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140358/new/
https://reviews.llvm.org/D140358
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
