jingham created this revision. jingham added reviewers: JDevlieghere, labath. Herald added a project: All. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits.
The presence of this entry causes the Xcode generator to produce two references to libLLVMSupport.a, one at the end of the list, and that causes the build to fail with a link error. The first version was pulled in when processing the CLANG_LIBS entries in the lldb/tools/lldb-instr/CMakeLists.txt. I looked around and the only places where we use LINK_COMPONENTS and CLANG_LIBS together are various lldb subdirectories that produce .a files but don't actually link anything. Anyway, this line doesn't seem to be needed for either the regular Ninja or the Xcode generator, and removing it makes the xcode build work again. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D142241 Files: lldb/tools/lldb-instr/CMakeLists.txt Index: lldb/tools/lldb-instr/CMakeLists.txt =================================================================== --- lldb/tools/lldb-instr/CMakeLists.txt +++ lldb/tools/lldb-instr/CMakeLists.txt @@ -11,6 +11,4 @@ clangSerialization clangTooling - LINK_COMPONENTS - Support )
Index: lldb/tools/lldb-instr/CMakeLists.txt =================================================================== --- lldb/tools/lldb-instr/CMakeLists.txt +++ lldb/tools/lldb-instr/CMakeLists.txt @@ -11,6 +11,4 @@ clangSerialization clangTooling - LINK_COMPONENTS - Support )
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits