avogelsgesang added a comment. > This change makes me a little nervous, but mostly because I don't quite > understand the design here. > So ASTImporter does not have a check whether src context and dst context are > identical?
I am completely with you. I also don't understand the design of `ASTImporter`. I had to learn the hard way that there are multiple ASTs around at the same time (one per object file + one for the "debugging session" in which all temporary types etc. are created). But I don't quite understand their lifetimes, and which types of cross-AST linking is supported and in which cases types need to be copied over. In that sense, I see this commit mostly as a basis for discussions, but I am not completely confident that this is the right solution. I would hope to find someone more experienced with lldb who can point me in the right direction :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143127/new/ https://reviews.llvm.org/D143127 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
