MaskRay added inline comments.
================
Comment at: clang-tools-extra/clangd/unittests/BackgroundIndexTests.cpp:638
- EXPECT_THAT(Storage.keys(), ElementsAre(testPath("A.cc"), testPath("A.h")));
+ EXPECT_THAT(Storage.keys(), ElementsAre(testPath("A.h"), testPath("A.cc")));
// Make sure we only store the Cmd for main file.
----------------
Rebase. I've changed this to `UnorderedElementsAre`
================
Comment at: clang-tools-extra/test/modularize/ProblemsInconsistent.modularize:6
-# CHECK: error: macro 'SYMBOL' defined at multiple locations:
-# CHECK-NEXT: {{.*}}{{[/\\]}}Inputs{{[/\\]}}InconsistentSubHeader.h:3:9
-# CHECK-NEXT: {{.*}}{{[/\\]}}Inputs{{[/\\]}}InconsistentSubHeader.h:7:9
-# CHECK-NEXT: error: macro 'FUNC_STYLE' defined at multiple locations:
+# CHECK: error: macro 'FUNC_STYLE' defined at multiple locations:
# CHECK-NEXT: {{.*}}{{[/\\]}}Inputs{{[/\\]}}InconsistentSubHeader.h:4:9
----------------
Rebase. I've fixed modularize's misuse of StringMap
https://llvm.org/docs/ProgrammersManual.html#llvm-adt-stringmap-h
> StringMap iteration order, however, is not guaranteed to be deterministic, so
> any uses which require that should instead use a std::map.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142862/new/
https://reviews.llvm.org/D142862
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
