mib added a comment. LGTM! Is there a simple way to test this ?
================ Comment at: lldb/source/Utility/Diagnostics.cpp:55-58 + m_callbacks.erase( + std::remove_if(m_callbacks.begin(), m_callbacks.end(), + [id](const CallbackEntry &e) { return e.id == id; }), + m_callbacks.end()); ---------------- nit: may be use `llvm::remove_if` instead ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143548/new/ https://reviews.llvm.org/D143548 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits