aaron.ballman added a comment.
In D146041#4198056 <https://reviews.llvm.org/D146041#4198056>, @AryanGodara
wrote:
> I will try to split this commit, and update on this asap (Sorry for the late
> update, I have mid-sem exams going on, I haven't abandoned this issue, still
> working on it).
No worries about the speed of updates, it's totally fine for weeks to pass
between updates to a patch. We're usually pretty good at asking "is this
abandoned" rather than assuming. FWIW, it looks like there's also precommit CI
failures related to the changes that should be looked into.
================
Comment at: clang/unittests/Format/FormatTest.cpp:11426
verifyFormat("[[gsl::suppress(\"clang-tidy-check-name\")]] void f() {}");
- verifyFormat("void f() [[deprecated(\"so sorry\")]];");
verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n"
----------------
These changes don't really do much -- it's a test case, so the wording is not
important, but what is important is retaining the string argument that is being
dropped. I'd roll back the changes to this file.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146041/new/
https://reviews.llvm.org/D146041
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
