sgraenitz added a comment. I think this is ready to land, but I will leave it here for a few more days to allow for further questions.
================ Comment at: lldb/test/Shell/helper/toolchain.py:46 + if config.objc_gnustep_dir: + build_script_args.append('--objc-gnustep-dir="{0}"'.format(config.objc_gnustep_dir)) ---------------- bulbazord wrote: > sgraenitz wrote: > > bulbazord wrote: > > > Why does {0} need quotes around it but the args above it don't? > > Good catch! That's due to spaces in Windows paths... > In that case, do we also need to add quotes around the other paths? Seems > like we're assuming that on windows those directories cannot have spaces in > them. (Not suggesting you need to do that here and now, just wondering for > the future) I'd like to keep it as proposed here: I added the quotes since the default install path for gnustep libobjc2 was under `Program Files` for me. The other paths refer to subfolders in the build directory and apparently it hasn't been a problem. I guess no-one selects a path with spaces to build LLDB. That makes sense to me. I wouldn't propose to add precautionary quotes around these paths. If you wish to do that, please post a review and discuss it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146058/new/ https://reviews.llvm.org/D146058 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits