jasonmolenda added a comment. One possible criticism I have of the current reason:watchpoint + description-up-to-three-integers is that we should add key-value pairs to the stop-info packet `wp-address:` `wp-index:` `wp-hit-address` and honestly, `silently-continue:` instead of doing an architectural hardcode in lldb. The remote stub is probably in the best position to know if this is a false positive watch trigger that needs to be silently moved past, instead of depending on "a third integer which isn't within the range of a watched region on MIPS". If I wanted to add a 4th field for "silently skip" to the current description, now I'm requiring that the stub reporting flag a false hit watchpoint needs to provide the first three always. And maybe it only has the one address or something.
Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147674/new/ https://reviews.llvm.org/D147674 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
