peter.smith added a comment. From the Arm side this looks good. Strictly speaking R_ARM_ABS32 doesn't require overflow checking, but in this context adding it makes sense. It is definitely the case that addends are signed in Arm, I guess there may be a 32-bit ABI that has unsigned REL addends, but I guess support can be added for that when needed.
================ Comment at: lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:2640 +static void ApplyELF32ABS32Relocation(Symtab *symtab, ELFRelocation &rel, + DataExtractor &debug_data, ---------------- IIUC the largest difference between this and ApplyELF64ABS32Relocation is the use of REL rather than RELA relocations. Perhaps worth naming it as `ApplyELF32ABS32RelRelocation` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147642/new/ https://reviews.llvm.org/D147642 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
