bulbazord created this revision.
bulbazord added reviewers: JDevlieghere, jingham, mib, clayborg.
Herald added a project: All.
bulbazord requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
This adds tests for:
- FileSpec::TestFileNameExtensions
- FileSpec::TestFileNameStrippingExtension
- FileSpec::IsSourceImplementationFile
This additionally updates incorrect documentation.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D147801
Files:
lldb/include/lldb/Utility/FileSpec.h
lldb/unittests/Utility/FileSpecTest.cpp
Index: lldb/unittests/Utility/FileSpecTest.cpp
===================================================================
--- lldb/unittests/Utility/FileSpecTest.cpp
+++ lldb/unittests/Utility/FileSpecTest.cpp
@@ -448,3 +448,59 @@
file.PrependPathComponent("/tmp");
EXPECT_TRUE(file.IsAbsolute());
}
+
+TEST(FileSpecTest, TestFileNameExtensions) {
+ FileSpec dylib = PosixSpec("/tmp/foo.dylib");
+ FileSpec exe = PosixSpec("/tmp/foo");
+ FileSpec dSYM = PosixSpec("/tmp/foo.dSYM/");
+ FileSpec just_dot = PosixSpec("/tmp/bar.");
+
+ EXPECT_TRUE(dylib.GetFileNameExtension() == ".dylib");
+ EXPECT_TRUE(exe.GetFileNameExtension() == ConstString(nullptr));
+ EXPECT_TRUE(dSYM.GetFileNameExtension() == ".dSYM");
+ EXPECT_TRUE(just_dot.GetFileNameExtension() == ".");
+
+ FileSpec dll = WindowsSpec("C:\\tmp\\foo.dll");
+ FileSpec win_noext = WindowsSpec("C:\\tmp\\foo");
+
+ EXPECT_TRUE(dll.GetFileNameExtension() == ".dll");
+ EXPECT_TRUE(win_noext.GetFileNameExtension() == ConstString(nullptr));
+}
+
+TEST(FileSpecTest, TestFileNameStrippingExtension) {
+ FileSpec dylib = PosixSpec("/tmp/foo.dylib");
+ FileSpec exe = PosixSpec("/tmp/foo");
+ FileSpec just_dot = PosixSpec("/tmp/bar.");
+
+ EXPECT_TRUE(dylib.GetFileNameStrippingExtension() == "foo");
+ EXPECT_TRUE(exe.GetFileNameStrippingExtension() == "foo");
+ EXPECT_TRUE(just_dot.GetFileNameStrippingExtension() == "bar");
+
+ FileSpec dll = WindowsSpec("C:\\tmp\\foo.dll");
+ FileSpec win_noext = WindowsSpec("C:\\tmp\\foo");
+
+ EXPECT_TRUE(dll.GetFileNameStrippingExtension() == "foo");
+ EXPECT_TRUE(win_noext.GetFileNameStrippingExtension() == "foo");
+}
+
+TEST(FileSpecTest, TestIsSourceImplementationFile) {
+ FileSpec c_src = PosixSpec("/tmp/foo.c");
+ FileSpec txt_file = PosixSpec("/tmp/foo.txt");
+ FileSpec executable = PosixSpec("/tmp/foo");
+ FileSpec just_dot = PosixSpec("/tmp/bar.");
+
+ EXPECT_TRUE(c_src.IsSourceImplementationFile());
+ EXPECT_FALSE(txt_file.IsSourceImplementationFile());
+ EXPECT_FALSE(executable.IsSourceImplementationFile());
+ EXPECT_FALSE(just_dot.IsSourceImplementationFile());
+
+ FileSpec cpp_src = WindowsSpec("C:\\tmp\\foo.cpp");
+ FileSpec dll = WindowsSpec("C:\\tmp\\foo.dll");
+ FileSpec win_noext = WindowsSpec("C:\\tmp\\foo");
+ FileSpec exe = WindowsSpec("C:\\tmp\\foo.exe");
+
+ EXPECT_TRUE(cpp_src.IsSourceImplementationFile());
+ EXPECT_FALSE(dll.IsSourceImplementationFile());
+ EXPECT_FALSE(win_noext.IsSourceImplementationFile());
+ EXPECT_FALSE(exe.IsSourceImplementationFile());
+}
Index: lldb/include/lldb/Utility/FileSpec.h
===================================================================
--- lldb/include/lldb/Utility/FileSpec.h
+++ lldb/include/lldb/Utility/FileSpec.h
@@ -253,7 +253,7 @@
/// (files with a ".c", ".cpp", ".m", ".mm" (many more) extension).
///
/// \return
- /// \b true if the filespec represents an implementation source
+ /// \b true if the FileSpec represents an implementation source
/// file, \b false otherwise.
bool IsSourceImplementationFile() const;
@@ -327,7 +327,7 @@
/// Returns a ConstString that represents the extension of the filename for
/// this FileSpec object. If this object does not represent a file, or the
/// filename has no extension, ConstString(nullptr) is returned. The dot
- /// ('.') character is not returned as part of the extension
+ /// ('.') character is the first character in the returned string.
///
/// \return Returns the extension of the file as a ConstString object.
ConstString GetFileNameExtension() const;
Index: lldb/unittests/Utility/FileSpecTest.cpp
===================================================================
--- lldb/unittests/Utility/FileSpecTest.cpp
+++ lldb/unittests/Utility/FileSpecTest.cpp
@@ -448,3 +448,59 @@
file.PrependPathComponent("/tmp");
EXPECT_TRUE(file.IsAbsolute());
}
+
+TEST(FileSpecTest, TestFileNameExtensions) {
+ FileSpec dylib = PosixSpec("/tmp/foo.dylib");
+ FileSpec exe = PosixSpec("/tmp/foo");
+ FileSpec dSYM = PosixSpec("/tmp/foo.dSYM/");
+ FileSpec just_dot = PosixSpec("/tmp/bar.");
+
+ EXPECT_TRUE(dylib.GetFileNameExtension() == ".dylib");
+ EXPECT_TRUE(exe.GetFileNameExtension() == ConstString(nullptr));
+ EXPECT_TRUE(dSYM.GetFileNameExtension() == ".dSYM");
+ EXPECT_TRUE(just_dot.GetFileNameExtension() == ".");
+
+ FileSpec dll = WindowsSpec("C:\\tmp\\foo.dll");
+ FileSpec win_noext = WindowsSpec("C:\\tmp\\foo");
+
+ EXPECT_TRUE(dll.GetFileNameExtension() == ".dll");
+ EXPECT_TRUE(win_noext.GetFileNameExtension() == ConstString(nullptr));
+}
+
+TEST(FileSpecTest, TestFileNameStrippingExtension) {
+ FileSpec dylib = PosixSpec("/tmp/foo.dylib");
+ FileSpec exe = PosixSpec("/tmp/foo");
+ FileSpec just_dot = PosixSpec("/tmp/bar.");
+
+ EXPECT_TRUE(dylib.GetFileNameStrippingExtension() == "foo");
+ EXPECT_TRUE(exe.GetFileNameStrippingExtension() == "foo");
+ EXPECT_TRUE(just_dot.GetFileNameStrippingExtension() == "bar");
+
+ FileSpec dll = WindowsSpec("C:\\tmp\\foo.dll");
+ FileSpec win_noext = WindowsSpec("C:\\tmp\\foo");
+
+ EXPECT_TRUE(dll.GetFileNameStrippingExtension() == "foo");
+ EXPECT_TRUE(win_noext.GetFileNameStrippingExtension() == "foo");
+}
+
+TEST(FileSpecTest, TestIsSourceImplementationFile) {
+ FileSpec c_src = PosixSpec("/tmp/foo.c");
+ FileSpec txt_file = PosixSpec("/tmp/foo.txt");
+ FileSpec executable = PosixSpec("/tmp/foo");
+ FileSpec just_dot = PosixSpec("/tmp/bar.");
+
+ EXPECT_TRUE(c_src.IsSourceImplementationFile());
+ EXPECT_FALSE(txt_file.IsSourceImplementationFile());
+ EXPECT_FALSE(executable.IsSourceImplementationFile());
+ EXPECT_FALSE(just_dot.IsSourceImplementationFile());
+
+ FileSpec cpp_src = WindowsSpec("C:\\tmp\\foo.cpp");
+ FileSpec dll = WindowsSpec("C:\\tmp\\foo.dll");
+ FileSpec win_noext = WindowsSpec("C:\\tmp\\foo");
+ FileSpec exe = WindowsSpec("C:\\tmp\\foo.exe");
+
+ EXPECT_TRUE(cpp_src.IsSourceImplementationFile());
+ EXPECT_FALSE(dll.IsSourceImplementationFile());
+ EXPECT_FALSE(win_noext.IsSourceImplementationFile());
+ EXPECT_FALSE(exe.IsSourceImplementationFile());
+}
Index: lldb/include/lldb/Utility/FileSpec.h
===================================================================
--- lldb/include/lldb/Utility/FileSpec.h
+++ lldb/include/lldb/Utility/FileSpec.h
@@ -253,7 +253,7 @@
/// (files with a ".c", ".cpp", ".m", ".mm" (many more) extension).
///
/// \return
- /// \b true if the filespec represents an implementation source
+ /// \b true if the FileSpec represents an implementation source
/// file, \b false otherwise.
bool IsSourceImplementationFile() const;
@@ -327,7 +327,7 @@
/// Returns a ConstString that represents the extension of the filename for
/// this FileSpec object. If this object does not represent a file, or the
/// filename has no extension, ConstString(nullptr) is returned. The dot
- /// ('.') character is not returned as part of the extension
+ /// ('.') character is the first character in the returned string.
///
/// \return Returns the extension of the file as a ConstString object.
ConstString GetFileNameExtension() const;
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
