[Lldb-commits] [PATCH] D148650: [lldb] Pass skip_exec=True in TestExec.test_skipping_exec

[Dave Lee via Phabricator via lldb-commits]

kastiglione created this revision.
kastiglione added a reviewer: jingham.
Herald added a project: All.
kastiglione requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

Fix the test to match the function name, by passing `skip_exec=True`.

Otherwise, both `test_hitting_exec` and `test_skipping_exec` are identical.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D148650

Files:
  lldb/test/API/functionalities/exec/TestExec.py


Index: lldb/test/API/functionalities/exec/TestExec.py
===================================================================
--- lldb/test/API/functionalities/exec/TestExec.py
+++ lldb/test/API/functionalities/exec/TestExec.py
@@ -19,8 +19,8 @@
     @expectedFailureNetBSD
     @skipIfAsan # rdar://problem/43756823
     @skipIfWindows
-    def test_hitting_exec (self):
-        self.do_test(False)
+    def test_hitting_exec(self):
+        self.do_test(skip_exec=False)
 
     @expectedFailureAll(archs=['i386'],
                         oslist=no_match(["freebsd"]),
@@ -29,8 +29,8 @@
     @expectedFailureNetBSD
     @skipIfAsan # rdar://problem/43756823
     @skipIfWindows
-    def test_skipping_exec (self):
-        self.do_test(True)
+    def test_skipping_exec(self):
+        self.do_test(skip_exec=True)
 
     def do_test(self, skip_exec):
         self.build()



Index: lldb/test/API/functionalities/exec/TestExec.py
===================================================================
--- lldb/test/API/functionalities/exec/TestExec.py
+++ lldb/test/API/functionalities/exec/TestExec.py
@@ -19,8 +19,8 @@
     @expectedFailureNetBSD
     @skipIfAsan # rdar://problem/43756823
     @skipIfWindows
-    def test_hitting_exec (self):
-        self.do_test(False)
+    def test_hitting_exec(self):
+        self.do_test(skip_exec=False)
 
     @expectedFailureAll(archs=['i386'],
                         oslist=no_match(["freebsd"]),
@@ -29,8 +29,8 @@
     @expectedFailureNetBSD
     @skipIfAsan # rdar://problem/43756823
     @skipIfWindows
-    def test_skipping_exec (self):
-        self.do_test(True)
+    def test_skipping_exec(self):
+        self.do_test(skip_exec=True)
 
     def do_test(self, skip_exec):
         self.build()

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits