mib requested changes to this revision.
mib added a comment.
This revision now requires changes to proceed.
I think we should still be able to use this new flag with the previous ones
(i.e. `watchpoint set -l c++ -w read -- &my_var`)
================
Comment at: lldb/source/Interpreter/OptionGroupWatchpoint.cpp:67
+ "Number of bytes to use to watch a region."},
+ {LLDB_OPT_SET_2,
+ false,
----------------
bulbazord wrote:
> jasonmolenda wrote:
> > I don't care much, but the formatting of this entry is pretty inconsistent
> > with the two SET_1's above. Should they match?
> I applied clang-format to the entire thing and this is what it gave me....
> /shrug
Having a different option group for this flag means it can't be used with the
other ones ... Is that really what you want ?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149111/new/
https://reviews.llvm.org/D149111
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
