bulbazord created this revision.
bulbazord added reviewers: JDevlieghere, mib, jingham.
Herald added a project: All.
bulbazord requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
There's no reason to create an entire new filespec to mutate and grab
data from when we can just grab the data directly.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D149625
Files:
lldb/source/API/SBFileSpec.cpp
Index: lldb/source/API/SBFileSpec.cpp
===================================================================
--- lldb/source/API/SBFileSpec.cpp
+++ lldb/source/API/SBFileSpec.cpp
@@ -114,9 +114,7 @@
const char *SBFileSpec::GetDirectory() const {
LLDB_INSTRUMENT_VA(this);
- FileSpec directory{*m_opaque_up};
- directory.ClearFilename();
- return directory.GetPathAsConstString().GetCString();
+ return m_opaque_up->GetDirectory().GetCString();
}
void SBFileSpec::SetFilename(const char *filename) {
Index: lldb/source/API/SBFileSpec.cpp
===================================================================
--- lldb/source/API/SBFileSpec.cpp
+++ lldb/source/API/SBFileSpec.cpp
@@ -114,9 +114,7 @@
const char *SBFileSpec::GetDirectory() const {
LLDB_INSTRUMENT_VA(this);
- FileSpec directory{*m_opaque_up};
- directory.ClearFilename();
- return directory.GetPathAsConstString().GetCString();
+ return m_opaque_up->GetDirectory().GetCString();
}
void SBFileSpec::SetFilename(const char *filename) {
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
