mib added a comment. This looks good to me, although I'm wondering whether instead of passing a string, we should pass a dictionary. This way the user could either fill the dictionary with a simple stop reason description or the MachException data What do you think Jim ?
================ Comment at: lldb/bindings/python/python-wrapper.swig:390 + if (PyErr_Occurred()) { + printf("Error occured for call to %s.\n", + method_name); ---------------- If we passed a `Status&` instead of a `bool&` we would be able to get that error message in lldb. ================ Comment at: lldb/examples/python/scripted_step.py:156 + def stop_description(self, stream): + self.step_thread_plan.GetDescription(s, lldb.eDescriptionLevelBrief) + ---------------- This is probably a typo ================ Comment at: lldb/include/lldb/Interpreter/ScriptInterpreter.h:320 + lldb_private::Stream *stream, + bool &script_error) { + script_error = true; ---------------- For Scripted Process, I pass a `Status&` argument which can hold an error message for better debugging. By doing so, you can also return `Status.Success()` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149692/new/ https://reviews.llvm.org/D149692 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits