bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, Michael137, jingham. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits.
I have a patch to refactor this class and I'd like a unittest in place to make sure I don't break anything. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D149804 Files: lldb/unittests/Language/CMakeLists.txt lldb/unittests/Language/ObjC/CMakeLists.txt lldb/unittests/Language/ObjC/ObjCLanguageTest.cpp
Index: lldb/unittests/Language/ObjC/ObjCLanguageTest.cpp =================================================================== --- /dev/null +++ lldb/unittests/Language/ObjC/ObjCLanguageTest.cpp @@ -0,0 +1,114 @@ +//===-- ObjCLanguageTest.cpp ----------------------------------------------===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception +// +//===----------------------------------------------------------------------===// +#include "Plugins/Language/ObjC/ObjCLanguage.h" +#include "lldb/lldb-enumerations.h" +#include "gmock/gmock.h" +#include "gtest/gtest.h" +#include <optional> + +#include "llvm/ADT/StringRef.h" + +using namespace lldb_private; + +TEST(ObjCLanguage, MethodNameParsing) { + struct TestCase { + llvm::StringRef input; + llvm::StringRef full_name_sans_category; + llvm::StringRef class_name; + llvm::StringRef class_name_with_category; + llvm::StringRef category; + llvm::StringRef selector; + }; + + TestCase strict_cases[] = { + {"-[MyClass mySelector:]", "", "MyClass", "MyClass", "", "mySelector:"}, + {"+[MyClass mySelector:]", "", "MyClass", "MyClass", "", "mySelector:"}, + {"-[MyClass(my_category) mySelector:]", "-[MyClass mySelector:]", + "MyClass", "MyClass(my_category)", "my_category", "mySelector:"}, + {"+[MyClass(my_category) mySelector:]", "+[MyClass mySelector:]", + "MyClass", "MyClass(my_category)", "my_category", "mySelector:"}, + }; + + TestCase lax_cases[] = { + {"[MyClass mySelector:]", "", "MyClass", "MyClass", "", "mySelector:"}, + {"[MyClass(my_category) mySelector:]", "[MyClass mySelector:]", "MyClass", + "MyClass(my_category)", "my_category", "mySelector:"}, + }; + + // First, be strict + for (const auto &test : strict_cases) { + ObjCLanguage::MethodName method(test.input, /*strict = */ true); + EXPECT_TRUE(method.IsValid(/*strict = */ true)); + EXPECT_EQ( + test.full_name_sans_category, + method.GetFullNameWithoutCategory(/*empty_if_no_category = */ true) + .GetStringRef()); + EXPECT_EQ(test.class_name, method.GetClassName().GetStringRef()); + EXPECT_EQ(test.class_name_with_category, + method.GetClassNameWithCategory().GetStringRef()); + EXPECT_EQ(test.category, method.GetCategory().GetStringRef()); + EXPECT_EQ(test.selector, method.GetSelector().GetStringRef()); + } + + // We should make sure strict parsing does not accept lax cases + for (const auto &test : lax_cases) { + ObjCLanguage::MethodName method(test.input, /*strict = */ true); + EXPECT_FALSE(method.IsValid(/*strict = */ true)); + } + + // All strict cases should work when not lax + for (const auto &test : strict_cases) { + ObjCLanguage::MethodName method(test.input, /*strict = */ false); + EXPECT_TRUE(method.IsValid(/*strict = */ false)); + EXPECT_EQ( + test.full_name_sans_category, + method.GetFullNameWithoutCategory(/*empty_if_no_category = */ true) + .GetStringRef()); + EXPECT_EQ(test.class_name, method.GetClassName().GetStringRef()); + EXPECT_EQ(test.class_name_with_category, + method.GetClassNameWithCategory().GetStringRef()); + EXPECT_EQ(test.category, method.GetCategory().GetStringRef()); + EXPECT_EQ(test.selector, method.GetSelector().GetStringRef()); + } + + // Make sure non-strict parsing works + for (const auto &test : lax_cases) { + ObjCLanguage::MethodName method(test.input, /*strict = */ false); + EXPECT_TRUE(method.IsValid(/*strict = */ false)); + EXPECT_EQ( + test.full_name_sans_category, + method.GetFullNameWithoutCategory(/*empty_if_no_category = */ true) + .GetStringRef()); + EXPECT_EQ(test.class_name, method.GetClassName().GetStringRef()); + EXPECT_EQ(test.class_name_with_category, + method.GetClassNameWithCategory().GetStringRef()); + EXPECT_EQ(test.category, method.GetCategory().GetStringRef()); + EXPECT_EQ(test.selector, method.GetSelector().GetStringRef()); + } +} + +TEST(CPlusPlusLanguage, InvalidMethodNameParsing) { + // Tests that we correctly reject malformed function names + + llvm::StringRef test_cases[] = {"+[Uh oh!", + "-[Definitely not...", + "[Nice try ] :)", + "+MaybeIfYouSquintYourEyes]", + "?[Tricky]", + "+[]", + "-[]", + "[]"}; + + for (const auto &name : test_cases) { + ObjCLanguage::MethodName strict_method(name, /*strict = */ true); + EXPECT_FALSE(strict_method.IsValid(true)); + + ObjCLanguage::MethodName lax_method(name, /*strict = */ false); + EXPECT_FALSE(lax_method.IsValid(true)); + } +} Index: lldb/unittests/Language/ObjC/CMakeLists.txt =================================================================== --- /dev/null +++ lldb/unittests/Language/ObjC/CMakeLists.txt @@ -0,0 +1,6 @@ +add_lldb_unittest(LanguageObjCTests + ObjCLanguageTest.cpp + + LINK_LIBS + lldbPluginObjCLanguage +) Index: lldb/unittests/Language/CMakeLists.txt =================================================================== --- lldb/unittests/Language/CMakeLists.txt +++ lldb/unittests/Language/CMakeLists.txt @@ -1,3 +1,4 @@ add_subdirectory(CPlusPlus) add_subdirectory(CLanguages) add_subdirectory(Highlighting) +add_subdirectory(ObjC)
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
